Attention is currently required from: Namyoon Woo.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54722 )
Change subject: dummyflasher.c: Move 'flashchip_contents' into emu_data
......................................................................
Patch Set 2:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54722/comment/5df3c737_dd2bc13e
PS2, Line 987: return 1;
There's lots of memory leaks here, e.g. `data` and `flashchip_contents`. […]
I'll leave that for https://review.coreboot.org/c/flashrom/+/54748 to resolve.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I11dfe713dd2fecfd3981ab50e31c9215d00bc787
Gerrit-Change-Number: 54722
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Namyoon Woo
namyoon@google.com
Gerrit-Comment-Date: Sun, 23 May 2021 12:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment