Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Joursoir.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54890 )
Change subject: programmer: Introduce default shutdown function
......................................................................
Patch Set 6:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/54890/comment/4a991178_7bcfd1f7
PS5, Line 104: function;
Do I right understand that you mean checking in register_*_master() and not in
register_shutdown()?
Actually I wasn't thinking which place (out of these two) is the best one. But we don't have to decide right now. The question was for future, when (and if) we decide that shutdown function needs to be required - at the moment it is not required.
It would be great to summarize this thread... Edward, what do you think about Angel's and my replies above? It was almost a year ago, but I still think in the same way :) There are few other comments, but that's essentially the same question.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8b20717ba549e12edffbc5d1643ff064a4f0c517
Gerrit-Change-Number: 54890
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Joursoir
chat@joursoir.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Joursoir
chat@joursoir.net
Gerrit-Comment-Date: Wed, 01 Jun 2022 02:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Joursoir
chat@joursoir.net
Gerrit-MessageType: comment