Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Kevin Yu.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67438 )
Change subject: ichspi: Add Intel Idaville HCC support ......................................................................
Patch Set 6: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67438/comment/cf2e5226_1a206db6 PS4, Line 9: IDs
Please also change IDs to ID
Done
https://review.coreboot.org/c/flashrom/+/67438/comment/43c5563c_a082cee8 PS4, Line 9: Add Cedar Fork PCH device IDs to enable flashrom on Idaville HCC platforms.
Just move the word "platforms" into the next line.
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/67438/comment/2dce06c0_977d67f8 PS6, Line 7: ichspi Sorry.. I just found this. This should be chipset_enable.c, since you are just changing a single file.
When this is changed, then it looks good :).