Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45944 )
Change subject: realtek_mst_i2c_spi.c: Fixup get_params() err ctrl flow ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/45944/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/45944/3//COMMIT_MSG@11 PS3, Line 11: Also renames the goto err cleanup path to make it clear.
It would have been a single-line fix, which would have been trivial.
That was my initial patch but then I realised the goto path didn't make any sense once the goto was dropped in one path and hence the rename together.
tbh, all my attention at the moment has been drawn to figuring out a spi jedec abstraction mechanism for wp to be well designed. So I just wanted to get it fixed for Shiyu to continue to make progress with Realtek and move back to that. Once again sorry it made it in too quickly, it was not my intention more I just didn't pay enough mental attention to it.