21 Dec
2021
21 Dec
'21
5:20 p.m.
Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59230 )
Change subject: Makefile: cleanup ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS3: Lol, found an old draft message that I never sent :) seems still valid. Also, the commit message needs an update.
File Makefile:
https://review.coreboot.org/c/flashrom/+/59230/comment/c54a765f_357683df PS1, Line 217: LDFLAGS += -lgetopt Don't these need an `override` too?
--
To view, visit https://review.coreboot.org/c/flashrom/+/59230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c9e869377677d624469af1ee9ece9a28fc3b559
Gerrit-Change-Number: 59230
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 21 Dec 2021 17:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment