[flashrom-gerrit] Change in flashrom[master]: raiden_debug: Upstream ChromiumOS servo debug board prog

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38209 )

Change subject: raiden_debug: Upstream ChromiumOS servo debug board prog
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/flashrom/+/38209/3/usb_device.h 
File usb_device.h:

https://review.coreboot.org/c/flashrom/+/38209/3/usb_device.h@64 
PS3, Line 64: return
> I have checked the patch in downstream, and it greatly improves readability. […]

Hey Angel,

Thanks very much. I am working through the licensing stuff as well here and as soon as I have the various things addressed brought up here merged in our branch i'll follow up with the revised usb_device.{h,c} and raiden programmer support patchsets. I also noticed this header really should have guards as well so I will fix that locally as well.