Attention is currently required from: Aarya, Anastasia Klimchuk, Nikolai Artemiev.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81548?usp=email )
Change subject: erasure_layout: don't copy region buffers if they're null/zero-size
......................................................................
Patch Set 2:
(1 comment)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/81548/comment/0c1561f9_cb1bdc70 :
PS1, Line 263: old_start_buf = (uint8_t *)malloc(old_start - region_start);
: if (!old_start_buf) {
: msg_cerr("Not enough memory!\n");
: ret = -1;
: goto _end;
: }
: old_end_buf = (uint8_t *)malloc(region_end - old_end);
: if (!old_end_buf) {
: msg_cerr("Not enough memory!\n");
: ret = -1;
: goto _end;
: }
Thanks for the details, Anastasia! Yeah, I will dive deeper to see possible solutions and understand […]
Sorry it took longer than I expected. Please, Anastasia, check out the new patch set
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81548?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I99aad4119f9c11bea75e3419926cc833bc1f68c5
Gerrit-Change-Number: 81548
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@chromium.org
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Sat, 11 May 2024 15:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment