Attention is currently required from: Angel Pons, Liam Flaherty.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69713 )
Change subject: flashchips.c: Add 4BA write to XM25Qx256C
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69713/comment/bf9222f4_516e56c5
PS2, Line 10: command (0x12) according to their datasheets, but the feature flag is not enabled in flashchips.c, so enable it to allow this feature to be used.
Wrap at 72 chars
https://review.coreboot.org/c/flashrom/+/69713/comment/62e2a8c3_ff26241f
PS2, Line 11:
Tested?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96c80762fcda2af6028c7a53d8c545b0c6565cbd
Gerrit-Change-Number: 69713
Gerrit-PatchSet: 2
Gerrit-Owner: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Comment-Date: Thu, 17 Nov 2022 06:21:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment