Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43894 )
Change subject: ichspi.c: Consolidate ich_spi_mode select into a switch stmt
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/43894/1/ichspi.c
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/43894/1/ichspi.c@2011
PS1, Line 2011: "for 100+ series PCH.\n");
nit: mention Apollo Lake too?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/43894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I35535c3dac9fa796d204d60e5fc72a7d5f85d706
Gerrit-Change-Number: 43894
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 26 Jul 2020 08:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment