Attention is currently required from: Angel Pons.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70388 )
Change subject: chipset_enable.c: add PCI ID for TGL-UP3 SPI controller
......................................................................
Patch Set 1:
(1 comment)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/70388/comment/3f2ba6c9_ace28d29
PS1, Line 2083: 0xa0a4
That's the SPI PCI device ID, do you have the LPC/eSPI PCI device ID?
You're right, this is probably the generic SPI. I will have to re-check...
--
To view, visit
https://review.coreboot.org/c/flashrom/+/70388
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie93af14eb5857bfe51964f6565e475b6249dd407
Gerrit-Change-Number: 70388
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 15 Dec 2022 12:58:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment