Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39687 )
Change subject: lspcon_i2c_spi.c: Add SPI-master support for PS17{5,6}
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/flashrom/+/39687/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/39687/4//COMMIT_MSG@18
PS4, Line 18: Tested with following commands, read/write/erase works good.
BUG=b:xxx […]
Done
https://review.coreboot.org/c/flashrom/+/39687/8/lspcon_i2c_spi.c
File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/39687/8/lspcon_i2c_spi.c@364
PS8, Line 364: uint8_t write_buffer[PAGE_SIZE + 1] = { 0 };
put this before the if and you may want to add the code comment I provided before about the prefix o […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/39687
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I039e683252cfaf1ffef8694a3e8081b1b6b944f7
Gerrit-Change-Number: 39687
Gerrit-PatchSet: 9
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 06:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment