Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40105 )
Change subject: raiden_debug_spi.c: Clean up global state
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40105/5/raiden_debug_spi.c
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/40105/5/raiden_debug_spi.c@473
PS5, Line 473: static int register_raiden_debug_spi_master(void *ptr)
: {
: struct spi_master mst = spi_master_raiden_debug;
: mst.data = ptr;
:
: return register_spi_master(&mst);
: }
Given that CB:40470 removes this kind of construct, why add it here?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ida9dce97fef2c6dfd68a278c879917fdd3ff7fef
Gerrit-Change-Number: 40105
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Apr 2020 09:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment