Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59528 )
Change subject: spi25_statusreg: inline spi_write_register_flag() ......................................................................
Patch Set 21:
(1 comment)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/59528/comment/8a816b03_f054947d PS21, Line 110: /* WRSR performs a self-timed erase before the changes take effect. : * This may take 50-85 ms in most cases, and some chips apparently : * allow running RDSR only once. Therefore pick an initial delay of : * 100 ms, then wait in 10 ms steps until a total of 5 s have elapsed. : */ : int i = 0; : programmer_delay(100 * 1000); : while (spi_read_status_register(flash) & SPI_SR_WIP) { : if (++i > 490) { : msg_cerr("Error: WIP bit after WRSR never cleared\n"); : return TIMEOUT_ERROR; : } : programmer_delay(10 * 1000); : } : return 0; This undoes changes to the waiting loop recently made in CB:58475.