Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41532 )
Change subject: raiden_debug_spi.c: Add protocol based configuration to init
......................................................................
Patch Set 15: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/41532/15/raiden_debug_spi.c
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41532/15/raiden_debug_spi.c@729
PS15, Line 729: return ret;
doesn't this early return result in a memory leak? Can be a follow up fix.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/41532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id404af14e55fa0884e29f28880206aaad4deba66
Gerrit-Change-Number: 41532
Gerrit-PatchSet: 15
Gerrit-Owner: Brian Nemec
bnemec@google.com
Gerrit-Reviewer: Brian Nemec
bnemec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jul 2020 01:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment