Attention is currently required from: Alan Green, Anastasia Klimchuk. Hello Alan Green, Anastasia Klimchuk,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/55697
to review the following change.
Change subject: ft2232_spi: Revise error message ......................................................................
ft2232_spi: Revise error message
Reword the message and drop the error string from libftdi. It is already printed in send_buf().
Change-Id: I125ae9ec0d5487fc26d588a7fd6c54da4ebd0d70 Signed-off-by: Nico Huber nico.h@gmx.de --- M ft2232_spi.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/55697/1
diff --git a/ft2232_spi.c b/ft2232_spi.c index fbea0f9..1404214 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -180,8 +180,7 @@ buf[1] = 0; /* Output byte ignored */ buf[2] = 0; /* Pin direction: all inputs */ if (send_buf(ftdic, buf, 3)) { - msg_perr("Unable to set pins back inputs: (%s)\n", - ftdi_get_error_string(ftdic)); + msg_perr("Unable to set pins back to inputs.\n"); ret = 1; }