31 May
2022
31 May
'22
11:23 a.m.
Attention is currently required from: Felix Singer, Nico Huber, Richard Hughes, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 )
Change subject: libflashrom: Allow getting the progress_state from the flashctx ......................................................................
Patch Set 2:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/64663/comment/8c23ef04_5041d233 PS2, Line 70: return flashctx->progress_state;
I read your comment and started thinking about this too. […]
We should create a patch that consistently introduces guards for parameter sanity.
--
To view, visit https://review.coreboot.org/c/flashrom/+/64663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes richard@hughsie.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Daniel Campello campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Richard Hughes richard@hughsie.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 31 May 2022 11:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment