Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35808 )
Change subject: Fix compilation if CONFIG_INTERNAL=no ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c@199 PS1, Line 199: Looks like the memory behind `supported_boards` is left uninitialized on the negative path?
https://review.coreboot.org/c/flashrom/+/35808/1/physmap.c File physmap.c:
https://review.coreboot.org/c/flashrom/+/35808/1/physmap.c@433 PS1, Line 433: #if CONFIG_INTERNAL == 1 Why does it need a guard? I don't see anything non-standard