[flashrom-gerrit] [M] Change in flashrom[master]: flashrom: rewrite flashbuses_to_text()

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Alexander Goncharov.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73039 )

Change subject: flashrom: rewrite flashbuses_to_text()
......................................................................

Patch Set 6:

(2 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/73039/comment/26e3b064_bafb86ca 
PS6, Line 17: `printf()`
I thought that's undefined behaviour, handling null in printf?

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/73039/comment/56ab58f8_e8a21938 
PS5, Line 948: if (bustype & (1 << i))
> Came back with fresh ideas, I see that it's possible to use a struct: […]

Looks good! I was a bit confused where is the code, but realised it's only in the comment for now, not in the latest patchset yet :)