Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 )
Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks
......................................................................
Patch Set 42:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65879/comment/4da1c3cd_d113ddce
PS41, Line 1237:
: struct erase_layout *create_erase_layout(struct flashctx *const flashctx);
:
Would it make sense for these functions to become part of layout. […]
These prototyes here are temporary until the functions are used. It's needed to trick -Wmissing-prototype or -Wunused-function.
erase_layout has nothing to do with the layout from layout.c
--
To view, visit
https://review.coreboot.org/c/flashrom/+/65879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4
Gerrit-Change-Number: 65879
Gerrit-PatchSet: 42
Gerrit-Owner: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Tue, 13 Dec 2022 08:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Aarya
aarya.chaumal@gmail.com
Gerrit-MessageType: comment