Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Add support for USB SPI protocol V2 ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1221 PS5, Line 1221: }
\n
Done
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1227 PS5, Line 1227: if (!status) { : if (read_ctx.receive_size == read_ctx.receive_index) { : /* Successful transfer. */ : return status; : } else { : /* Report the error from the failed read. */ : status = USB_SPI_HOST_RX_READ_FAILURE; : } : } : : if (status) {
Is this just equivalent to: […]
Not quite, I only want to replace the status flag in the branch where no errors were reported.
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1257 PS5, Line 1257: }
\n
Done
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c@1338 PS12, Line 1338: it's
nit: possessive `its`
Done