Nico Huber has posted comments on this change. ( https://review.coreboot.org/20505 )
Change subject: 4BA: Flashrom integration for the 4-bytes addressing extensions
......................................................................
Patch Set 2:
The major issue that I see is that the added function pointers are all
for naught. They are redundant information that can already be sta-
tically decided by the feature bits (if we keep the _DIRECT features
in the end).
--
To view, visit
https://review.coreboot.org/20505
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib051cfc93bd4aa7580519e0e6206d025f3ca8049
Gerrit-Change-Number: 20505
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Tauner
stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Oct 2017 14:25:49 +0000
Gerrit-HasComments: No