Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58737 )
Change subject: ichspi: Extract initialisation of swseq and hwseq into a function
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58737/comment/21c787b0_9a535def
PS1, Line 15: daclare
d*e*clare
Done
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/58737/comment/6ae5099f_46021e74
PS1, Line 1786: size_t *num_freg, size_t *num_pr, size_t *reg_pr0,
Technically these are not about sw/hw sequencing. Maybe just rename the […]
Done
https://review.coreboot.org/c/flashrom/+/58737/comment/ab5bc8e3_dd184eef
PS1, Line 1787: enum ich_chipset ich_gen)
looks like one space is missing, or is Gerrit fooling me?
It was missing, you are right.
https://review.coreboot.org/c/flashrom/+/58737/comment/cb79e10b_78872f0e
PS1, Line 1818: }
Add a line break here
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7d62b1b380e497b82dcae1284d752204cc541bd3
Gerrit-Change-Number: 58737
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 22 Dec 2021 06:11:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment