8 Mar
2023
8 Mar
'23
8:06 p.m.
Attention is currently required from: Edward O'Callaghan, Piotr Halama, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 )
Change subject: flashchips: Add support for Boya BY25D80A ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/73513/comment/77b20026_ee962d55 PS2, Line 3533: .
It seems like the same chip is sold with multiple names, since page 13 of [BH25D80](https://datashee […]
Ack, thanks for catching.
Can you rename the `.model_id` to `BOYA_BOHONG_B__25D80A`. This is done at multiple locations is flashchips.h
--
To view, visit https://review.coreboot.org/c/flashrom/+/73513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7
Gerrit-Change-Number: 73513
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Halama skrzynka@halamix2.pl
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Piotr Halama skrzynka@halamix2.pl
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 08 Mar 2023 23:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Peter Marheine pmarheine@chromium.org
Gerrit-MessageType: comment