[flashrom-gerrit] Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops

[Michał Żygowski (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner, Sergii Dmytruk.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )

Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
......................................................................

Patch Set 24:

(1 comment)

File ite_ecfw.c:

https://review.coreboot.org/c/flashrom/+/55715/comment/4831a1e6_b6ee3984 
PS20, Line 332: 		if (blocks_1_2) {
              : 			itestring->flags.clock_source = CLOCK_SOURCE_INTERNAL;
              :
> Maybe, maybe not :S Let's keep it for now but add a comment

The datasheet also says the clock source bit should be always 1. The only path that selects external source is the autoload off when the flash size is larger than 128k. Maybe later we can force the internal oscillator in all paths and remove the comment...