24 Feb
2022
24 Feb
'22
2:53 p.m.
Attention is currently required from: Sam McNally, Nico Huber, Subrata Banik, Rizwan Qureshi, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 )
Change subject: ichspi: Add Alder Lake support ......................................................................
Patch Set 11:
(1 comment)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/62251/comment/97115816_5cdad4a8 PS10, Line 2154: {0x8086, 0x7aa4, B_S, DEP, "Intel", "Alder Lake-S", enable_flash_pch600},
No, he said it can be removed. […]
Please don't remove the entry for ADL-S, just leave it there as NT (Not Tested). It most likely works, someone will eventually test it and report on the mailing list.
--
To view, visit https://review.coreboot.org/c/flashrom/+/62251
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf
Gerrit-Change-Number: 62251
Gerrit-PatchSet: 11
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Thu, 24 Feb 2022 14:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment