[flashrom-gerrit] Change in flashrom[master]: support variable-size SPI chip for dummy programmer

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44879 )

Change subject: support variable-size SPI chip for dummy programmer
......................................................................

Patch Set 8:

(2 comments)

This doesn't seem like anybody has read this. It breaks the dummyflasher,
uses discouraged functions (like atoi()), didn't update the manpage...

https://review.coreboot.org/c/flashrom/+/44879/8/dummyflasher.c 
File dummyflasher.c:

https://review.coreboot.org/c/flashrom/+/44879/8/dummyflasher.c@159 
PS8, Line 159: VARIOUS
VARIABLE_SIZE?

https://review.coreboot.org/c/flashrom/+/44879/8/dummyflasher.c@291 
PS8, Line 291: 		return 1;
What about all the other emulation targets?

I'll stop reading here.