Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52597 )
Change subject: mec1308.c: Separate shutdown from failed init cleanup ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File mec1308.c:
https://review.coreboot.org/c/flashrom/+/52597/comment/563f50bb_3d74365e PS2, Line 496: goto mec1308_init_exit; It's becoming more and more obvious that the original cleanup procedure was insufficient. If we get here, we already disable "ACPI" (whatever that means, I guess SCIs). So we should try to clean that up too, shouldn't we?
We could either run the full cleanup, or add more labels (we'd need to revert to PS1, sorry). If you decide for the former, that could be a follow-up commit.
https://review.coreboot.org/c/flashrom/+/52597/comment/c5b0b7a9_f7541409 PS2, Line 519: failed_init_cleanup: : mec1308_shutdown(ctx_data); : return 1; : : mec1308_init_exit: Would be nice to align the label names somehow. I first thought "aren't both about failed init?", but there's (almost, see other comment) a difference: In one case we actually changed hardware state. So how about
failed_init_cleanup:
failed_prep_cleanup:
?