Attention is currently required from: Matt DeVillier.
Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email )
Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ......................................................................
Patch Set 3:
(6 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/85159/comment/a6830f11_b430c68b?usp... : PS2, Line 691: if (read_buf_from_include_args(get_layout(flash), newcontents))
I don't think so - we check if there is a filename following -r/-w/-v, and if so read the file into […]
Yeah you are right. I think I wrote this comment in the beginning of reviewing, and then looked through the rest of the change. Resolving this.
https://review.coreboot.org/c/flashrom/+/85159/comment/0814c2e2_8c30607c?usp... : PS2, Line 727: if (read_buf_from_include_args(get_layout(flash), newcontents))
same as above
Done
https://review.coreboot.org/c/flashrom/+/85159/comment/74384811_8da42d86?usp... : PS2, Line 1351: then: : * - Do partial read for each -i arg, creating a new file for : * each region where a filename is provided (-i region:filename). : * - Create a ROM-sized file with partially filled content. For each : * -i arg, fill the corresponding offset with content from ROM.
no, -r is the exception here.
Yes, now I see it! Your new formatting of the long comment works, it is more readable now!
https://review.coreboot.org/c/flashrom/+/85159/comment/74d33814_fca299df?usp... : PS2, Line 1357: Rules for writing and verifying:
I went to re-write this section based on your comments, but feel that it is actually correct as-is. […]
Readability accomplished. I only have two tiny comments left (for this comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/85159/comment/c83ea5bd_cf7eca3b?usp... : PS3, Line 1344: There are few trailing spaces (shown in gerrit in bright pink) in this comment
https://review.coreboot.org/c/flashrom/+/85159/comment/99152410_a78aae67?usp... : PS3, Line 1366: * - If file is specified for -w/-v and no files are specified with -i : * args, then the file is to be used for writing/verifying the entire : * ROM. Maybe this one can be promoted to common rules? It does apply to all of them -r/-w/-v ?