9 Dec
2022
9 Dec
'22
11:01 a.m.
Attention is currently required from: Simon Buhrow, Nico Huber, Aarya, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm ......................................................................
Patch Set 70: Code-Review+2
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/f40f1d2c_0f48684d PS70, Line 23: #include <assert.h> This is not longer needed.
https://review.coreboot.org/c/flashrom/+/66104/comment/c34a15e7_7343f4bd PS70, Line 1412: //if ret!=0 ?? Please remove this and other leftovers
--
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 70
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Fri, 09 Dec 2022 19:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment