26 Sep
2020
26 Sep
'20
8:58 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40325 )
Change subject: Add writeprotect support infrastructure ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Thank you!
https://review.coreboot.org/c/flashrom/+/40325/10/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/40325/10/cli_classic.c@656 PS10, Line 656: fill_flash->chip->wp This can be done in another patch, but I think we can test this condition for all write-protect operations in a single place for simplicity. I'll look into it.
--
To view, visit https://review.coreboot.org/c/flashrom/+/40325
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id93b5a1cb2da476fa8a7dde41d7b963024117474
Gerrit-Change-Number: 40325
Gerrit-PatchSet: 10
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Damien Zammit
Gerrit-CC: David Hendricks david.hendricks@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Sep 2020 06:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment