Attention is currently required from: Nico Huber, Angel Pons. David Bartley has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54968 )
Change subject: flashchips: add support for Winbond W25Q01JV ......................................................................
Patch Set 3:
(7 comments)
Patchset:
PS3: PTAL
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/54968/comment/6c32e1ab_addeeaf7 PS1, Line 17745: 5
The `5` seems spurious?
Done
https://review.coreboot.org/c/flashrom/+/54968/comment/b6d3b189_ac73f07a PS1, Line 17745: W25Q501V
Flash chip entries are sorted alphabetically by vendor and name. […]
Done
https://review.coreboot.org/c/flashrom/+/54968/comment/4e13b08f_4a3bd4d6 PS1, Line 17757: /* Full chip erase is fastest, typically takes 200s */
Block erasers for the other flash chip entries are intentionally sorted in ascending block size. […]
Fair enough, I can start a thread on the mailing list exploring options. FTR, it takes almost an hour to erase using the 4kb block eraser...
https://review.coreboot.org/c/flashrom/+/54968/comment/673b435b_439d368b PS1, Line 17781: spi_prettyprint_status_register_plain
spi_prettyprint_status_register_bp3_srwd
Done
https://review.coreboot.org/c/flashrom/+/54968/comment/fbbbfe10_e49e2591 PS1, Line 17782: spi_disable_blockprotect
spi_disable_blockprotect_bp3_srwd
Done
https://review.coreboot.org/c/flashrom/+/54968/comment/4f3b7ddc_50dca430 PS1, Line 17788:
nit: use only one blank line (there's two right now)
Done