30 Jul
2019
30 Jul
'19
5:32 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 )
Change subject: Fix -Wunused-parameter issues ......................................................................
Patch Set 5:
Are there any of these parameters that could be deleted, or were they all needed?
I removed unused parameters from static functions. Didn't check the APIs, though.
Much of the noise seems to be due to the usage of global variables, btw. Can't say how often I wrote `(void)flash;`, where `flash` is a reference to the context that was unused and something global instead. Sooner or later, those should be cleaned up anyway. If we take libflashrom serious.
--
To view, visit https://review.coreboot.org/c/flashrom/+/30410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 17:32:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment