Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Alexandru Stan has posted comments on this change by Alexandru Stan. ( https://review.coreboot.org/c/flashrom/+/84752?usp=email )
Change subject: flashchips: add Winbond W25R512NW / W74M51NW ......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS3: PTAL
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/84752/comment/e23ab8cb_f53609eb?usp... : PS1, Line 20271: 1650
ah, but you already updated the voltage according to datasheet. I am resolving this.
Yeah, the copied voltages from the other chip were not matching the datasheet, so that's what my comment meant. I updated it to follow the datasheet now.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/84752/comment/82432dc3_a9da36ff?usp... : PS2, Line 20230: W25R512NW
The situation you described in the following two lines, we do the following: […]
Done
https://review.coreboot.org/c/flashrom/+/84752/comment/0bf4684b_91da46ae?usp... : PS2, Line 20239: 1024B total, 256B reserved
I have something! Another developer kindly explained to me about OTP (in another patch CB:84827), an […]
Done
https://review.coreboot.org/c/flashrom/+/84752/comment/d6eb7120_0bd348b8?usp... : PS2, Line 20269: .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, : .unlock = SPI_DISABLE_BLOCKPROTECT, :
It'd be nice to add full WP support, reusing the values from `W25Q512NW-IM` should work here. […]
Sorry Nikolai. I'm not an expert at WPing and I very rarely even connect my programmer to a chip. Feel free to make a follow up patch.