Konstantin Grudnev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34496 )
Change subject: Add support for M95M02-A125 ......................................................................
Patch Set 1:
(1 comment)
some answers are needed
https://review.coreboot.org/c/flashrom/+/34496/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34496/1/flashchips.c@14121 PS1, Line 14121: .eraseblocks = { { 256 * 1024, 1 } },
Alternatively to handle pages in spi_block_erase_emulation(), […]
what do you mean by declaring { 256, 1 } ? I tried it and it tries to erase only first 256 bytes, also tried .eraseblocks { 256, 1024 } and it doesn't work, cause eraseblocks.count is not used in .block_erase() function in no shape or form, so the only way to compute eraseblocks.count is to divide total_size(256KiB)/blocklen(256) = 1024. So, your comment needs more elaboration, or I will leave it as it is.