Attention is currently required from: Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62851 )
Change subject: hwaccess_x86_msr: rename msr function to msr_xxx
......................................................................
Patch Set 4:
(1 comment)
File hwaccess_x86_msr.c:
https://review.coreboot.org/c/flashrom/+/62851/comment/c3c41f3e_4d239b2f
PS4, Line 302: * DirectHW has identical, but conflicting typedef for msr_t. We redefine msr_t
If it's identical, couldn't we just cast from one type to the other?
I wasn't able to do so. Maybe there is a trick I didn't know. That's the way that I found working.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4
Gerrit-Change-Number: 62851
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 09:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment