Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57269 )
Change subject: tests: Add NOT_ZERO and NOT_NULL macros to the header file
......................................................................
Patch Set 1:
(2 comments)
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/57269/comment/6ae282cb_b652a755
PS1, Line 37: NOT
NONZERO ?
https://review.coreboot.org/c/flashrom/+/57269/comment/687488af_c3b05cd2
PS1, Line 38: NOT_NULL ((void *)NOT_ZERO)
I wonder if this should be a function ptr address so that you can set a break point on the address easily as it has a named symbol associated with the address number. A stub function would be sufficient to serve this purpose. `void * nonnull(void) { return (void *)NONZERO; }`
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57269
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5ad6ee4aa9091447c6c9108c92bf7f6e755fca48
Gerrit-Change-Number: 57269
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 04:09:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment