Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Liam Flaherty.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68364 )
Change subject: raiden_debug_spi: Remove fixme with explanation
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Ok for now. […]
Yeah we had a larger idea of refactoring around `struct dev_entry` but that would be obviously a larger change, over multiple programmers etc, so does not fit into a small ticket which asks to Fix the Fixme from one given programmer.
That would be a different ticket with full description covering the idea, it can also be a longer discussion of course.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43e364c02f42dd499d3c9ca3e0a03ead673da3e6
Gerrit-Change-Number: 68364
Gerrit-PatchSet: 2
Gerrit-Owner: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Comment-Date: Mon, 17 Oct 2022 21:23:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment