Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47908 )
Change subject: Makefile: Explicitly set '-std=c99 -D_GNU_SOURCE'
......................................................................
Patch Set 1:
Please always test such heavy changes on many host systems,
(e.g. with manibuilder) to make sure there's not more GNUism
than non-gnu systems can take.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4f973927fc018510a3beaa6c4fa2f356c77c7a6e
Gerrit-Change-Number: 47908
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 12:51:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment