Attention is currently required from: Anastasia Klimchuk.
Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/83673?usp=email )
Change subject: Remove the Makefile ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2:
I tried git grep -n 'Makefile' and found some stuff which is not covered in this patch: […]
I found those too, and decided they didn't need to be changed. All of the "Makefile" references in `Doxyfile` refer to a Makefile that doxygen can emit, and manibuilder is self-contained (it just happens to use make as a way to specify a lot of similar tasks).
manibuilder is partially broken because it tries to use obsolete versions of some distributions (at least of Debian), but at least some of its targets (I tried Fedora 25) still work after applying this patch.
File doc/dev_guide/building_with_make.rst:
PS2:
Should this be removed from index file of dev_guide directory? I would expect sphinx to complain whe […]
It does generate a warning if you refer to a missing file. Removed.
File doc/release_notes/v_1_5-devel.rst:
https://review.coreboot.org/c/flashrom/+/83673/comment/9f246ab3_def78637?usp... : PS2, Line 2: v1.5-devel
I was thinking to have a generic name to this file, for example next_release. […]
That makes sense. Renamed and removed references to version 1.5, and I copied the known issue with AMD chipsets since it remains a known issue until it's fixed.
https://review.coreboot.org/c/flashrom/+/83673/comment/e7b9afd0_099ddb3d?usp... : PS2, Line 4: : This document describes the major changes to flashrom since the release : of version 1.4. These changes will be included in the future v1.5 release.
In the same spirit, I would make the intro generic, so that we need to compose it once and it stays […]
Done.