Attention is currently required from: Nico Huber, Nikolai Artemiev.
Hello build bot (Jenkins), Subrata Banik, Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/69195
to look at the new patch set (#15).
Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip` ......................................................................
ichspi.c: Read chip ID and use it to populate `flash->chip`
Read the flash chip vendor/device ID using hardware sequencing, find the corresponding flashchip entry, and copy it over to `flash->chip`.
Identifying the chip was not previously required as ICH hardware sequencing handles chip-level details related to read/write/erase ops.
However writeprotect operations require the chip entry to be identified so that chip->reg_bits can be used to compute status register values.
BUG=b:253715389,b:253713774 BRANCH=none TEST=flashrom on dedede (JSL) identifies "W25Q128.V..M" chip TEST=flashrom -{r,v} on dedede TEST=write/erase bios region on dedede: flashrom -{E,w} --layout <(echo '0x381000:0xffffff bios') -i bios
Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6 Signed-off-by: Nikolai Artemiev nartemiev@google.com --- M ichspi.c 1 file changed, 101 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/69195/15