6 May
2022
6 May
'22
8:56 p.m.
Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64026 )
Change subject: meson: relocate source file list ......................................................................
Patch Set 1:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64026/comment/06265ca8_67636284 PS1, Line 395: # core modules needed by both the library and the CLI
the comment got lost
I don't see this comment as important. Later in the chain it gets also irrelevant because we are linking against all those files in libflashrom.a
--
To view, visit https://review.coreboot.org/c/flashrom/+/64026
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I921be8a8a99b93d23c1dbd4ea54672ba9998558d
Gerrit-Change-Number: 64026
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Comment-Date: Fri, 06 May 2022 20:56:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Gerrit-MessageType: comment