[flashrom-gerrit] Change in flashrom[master]: Add a SPI command class to `struct flashchip`

[Paul Kocialkowski (Code Review)]

Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23262 )

Change subject: Add a SPI command class to `struct flashchip`
......................................................................

Patch Set 5: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/23262/4/flash.h
File flash.h:

https://review.coreboot.org/#/c/23262/4/flash.h@186
PS4, Line 186: 	/*
> It's obviously unmaintained because it documents this struct in […]

Okay, let's deal with that in a follow-up patch then.

https://review.coreboot.org/#/c/23262/5/flashrom.c
File flashrom.c:

https://review.coreboot.org/#/c/23262/5/flashrom.c@1213
PS5, Line 1213: SPI25
> Could as well be a parameter to this function.

That would probably help with command line integration, indeed, but can also be left to do in that follow-up commit. Your call.