Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41608 )
Change subject: raiden_debug_spi.c: Adds context states and helper functions ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/flashrom/+/41608/14/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41608/14/raiden_debug_spi.c@489 PS14, Line 489: send_comman Please keep the moving stuff around and rename patches separated from the one with the detail semantic changes. I think that should makes it easier for Angel and I to review.
https://review.coreboot.org/c/flashrom/+/41608/14/raiden_debug_spi.c@538 PS14, Line 538: write count = %u\n" some of this hunk can go into the previous clean up patch.
https://review.coreboot.org/c/flashrom/+/41608/14/raiden_debug_spi.c@570 PS14, Line 570: " write count = %u\n" ditto
https://review.coreboot.org/c/flashrom/+/41608/14/raiden_debug_spi.c@657 PS14, Line 657: *ctx_data = : (struct raiden_debug_spi_d this change can go into the previous clean up patch.