Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64028 )
Change subject: meson: use built-in options for install paths
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64028/comment/16f46c8c_b875c10c
PS2, Line 13: Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com
I noticed you are using different emails, the owner is one and signed-off is different, is it WAI?
File meson.build:
https://review.coreboot.org/c/flashrom/+/64028/comment/0fd8d017_244c70f1
PS2, Line 408: libdir = join_paths(prefix, get_option('libdir'))
So `libdir` was unused?!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64028
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9cb9faf4bdbcfd66098478cc3a260eb3b664a2e6
Gerrit-Change-Number: 64028
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 08 May 2022 23:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
