[flashrom-gerrit] [M] Change in flashrom[master]: ichspi: Clear Fast SPI HSFC register before HW seq operation

[Subrata Banik (Code Review)]

Attention is currently required from: Nikolai Artemiev, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69788 )

Change subject: ichspi: Clear Fast SPI HSFC register before HW seq operation
......................................................................

Patch Set 1:

(1 comment)

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/69788/comment/2b0e49d3_2b418b05 
PS1, Line 1360: /* make sure HSFC register is cleared before initiate any operation */
              : 	REGWRITE16(ICH9_REG_HSFC, 0);
              : 
              : 	/* Set up transaction parameters. */
              : 	hsfc = REGREAD16(ICH9_REG_HSFC);
> Couldn't this be simplified?

Something like this ?

uint16_t hsfc = 0;

hsfc |= hsfc_cycle;
hsfc |= HSFC_FDBC_VAL(len - 1);
hsfc |= HSFC_FGO; /* start */
prettyprint_ich9_reg_hsfc(hsfc, ich_generation);
REGWRITE16(ICH9_REG_HSFC, hsfc);