12 Apr
2022
12 Apr
'22
1:37 p.m.
Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63584 )
Change subject: ichspi: Add support for Ice Lake ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63584/comment/b0df2f89_e377a109 PS1, Line 7: ichspi: Add support for Ice Lake Technically, it's already supported. Why do we need to do more than changing the PCI ID?
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/63584/comment/af74a6aa_e86969fc PS1, Line 2149: 0x34a4 Is the SPI device guaranteed not to be hidden on Ice Lake?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If000b152c6e454617a7ad0245d16f8b1dea97fa0
Gerrit-Change-Number: 63584
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:37:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment