3 Feb
2020
3 Feb
'20
10:01 a.m.
Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38668 )
Change subject: meson: Sort options alphabetically ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review-1
This patch misses half of the necessary changes.
Necessary?
Please fix the other occurrences in meson.build as well.
Which lines are you referring to? The ones in the conditional code?
Yes, those. Could you please resubmit with those changes as well? Thanks.
--
To view, visit https://review.coreboot.org/c/flashrom/+/38668
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I77f97dc8ba0cfb2bec38342a80ace7b98ed00d37
Gerrit-Change-Number: 38668
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Feb 2020 10:01:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment