Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email )
Change subject: doc: Add build instructions for NI-845x on Windows
......................................................................
Patch Set 3:
(1 comment)
File doc/dev_guide/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/75270/comment/a2c78aaa_ca40b9a7 :
PS1, Line 92: for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration.
Ah okay, I have not been aware of that. In this case it is fine for me.
CB:75125 has been merged. So, how about adding information about ni-845x to the `building_with_make` file?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75270?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a
Gerrit-Change-Number: 75270
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov
chat@joursoir.net
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 30 May 2023 13:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton
martonmiklosqdev@gmail.com
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment
