Attention is currently required from: Sam McNally, Peter Marheine.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52405 )
Change subject: lspcon, realtek_mst: move i2c bus resolution from params to i2c_helper
......................................................................
Patch Set 8:
(2 comments)
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/52405/comment/d38ae2df_cd934ecb
PS6, Line 42: char *dev = malloc(sizeof(I2C_DEV_PREFIX));
It must because this ultimately gets returned from i2c_buspath_from_programmer_params where the leng […]
I see. Let me try another approach...
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/52405/comment/80b279cc_2ea3b033
PS8, Line 48: {
nit: another brace that needs to be moved
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieea57b2445f3aca16c87d8f839dff131009531a0
Gerrit-Change-Number: 52405
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 20 Apr 2021 08:05:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment