Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34363 )
Change subject: libflashrom: add querying functions with meson integration
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
I missed these.
https://review.coreboot.org/c/flashrom/+/34363/2/libflashrom.h
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/34363/2/libflashrom.h@41
PS2, Line 41: typedef
Oh no, typedefs
https://review.coreboot.org/c/flashrom/+/34363/2/libflashrom.h@49
PS2, Line 49: typedef
There's more! O_o
https://review.coreboot.org/c/flashrom/+/34363/2/libflashrom.h@53
PS2, Line 53: struct flashrom_tested {
: flashrom_test_state probe;
: flashrom_test_state read;
: flashrom_test_state erase;
: flashrom_test_state write;
: } tested;
enums on structs?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34363
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I49041b8fa5700dabe59fef0d2337339d34cd6c6f
Gerrit-Change-Number: 34363
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: ?ukasz Dmitrowski
lukasz.dmitrowski@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mario Limonciello
superm1@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Sep 2019 22:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment